Repository navigation
Fixes for alsa-info.sh errors at parsing system environment - #336
Merged
Merged
Conversation
Some modules are without any parameters, and there are no "parameters" subdirectories for such modules. Since alsa-info.sh tries to access modules/* files, this results in (non-fatal) errors. Add the check of the parameters subdirectory before accessing the actual parameter files for avoiding such errors. Link: https://bugzilla.suse.com/show_bug.cgi?id=1279431 Signed-off-by: Takashi Iwai <tiwai@suse.de>
The SoundWire device status information is gathered from ACPI adr sysfs files, but since we take only the entries for the known vendors, this list can be empty, resulting in no $TEMPDIR/sdwstatus.tmp file created. This will end up with the unexpected (non-fatal) errors for alsa-info.sh. For addressing it, add the check of the existence of tmp file before reading it. Link: https://bugzilla.suse.com/show_bug.cgi?id=1279431 Signed-off-by: Takashi Iwai <tiwai@suse.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There have been a few errors from alsa-info.sh at gathering and processing the system environment, as found in openSUSE bugzilla (https://bugzilla.suse.com/show_bug.cgi?id=1279431).
Here are trivial fixes.