Repository navigation
Include keyword-only defaults in step parameters - #934
Open
taltal-beep wants to merge 1 commit into
Open
taltal-beep wants to merge 1 commit into
taltal-beep wants to merge 1 commit into
Conversation
func_parameters() collected defaults of positional parameters only, so a keyword-only parameter left at its default was missing from the step parameters, and a step title placeholder referring to it raised KeyError.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Taltal
Context
func_parameters()collects the defaults of positional parameters but not of keyword-only ones. So withcalling
wait()raisesKeyError: 'timeout'from the step decorator and the test ends up broken, and even without a placeholder the parameter is missing from the step's parameters in the report. Positional defaults have been included since #440/#227.The fix adds
kwonlyargsto the parameter order andkwonlydefaultsto the collected values; explicitly passed keywords still win.Note: #910 builds a separate defaults map for the step title from
arg_spec.defaultsand would need the same handling.Checklist