Skip to content

Update for Microsoft bumping to React 16+ - #271

Open
kroeschl wants to merge 2 commits into
alejandro5042:masterfrom
kroeschl:ms-react-change
Open

kroeschl wants to merge 2 commits into
alejandro5042:masterfrom
kroeschl:ms-react-change

Conversation

@kroeschl

Copy link
Copy Markdown
Contributor

Justification

Microsoft bumped to React 16.x or newer, which broke the reviewer and file annotations on the pull request page. For example, I now see an error like the following when trying to view the reviewer page:

Uncaught (in promise) TypeError: can't access property "return", getPropertyThatStartsWith(...) is undefined
    watchForReviewerList ... More Awesome Azure DevOps (userscript).user.js#5:2867
    onEveryNew ... More Awesome Azure DevOps (userscript).user.js#5:203
    watchForReviewerList ... More Awesome Azure DevOps (userscript).user.js#5:2865
    onReady ... More Awesome Azure DevOps (userscript).user.js#5:1922
    onUrl ... More Awesome Azure DevOps (userscript).user.js#5:322
    onUrlChange ... More Awesome Azure DevOps (userscript).user.js#5:302
    onUrl ... More Awesome Azure DevOps (userscript).user.js#5:317
    onReady ... More Awesome Azure DevOps (userscript).user.js#5:1919
    main ... More Awesome Azure DevOps (userscript).user.js#5:1890

Implementation

Newer React replaces __reactInternalInstance$ with __reactFiber$, so switch to that. Bump our version, but not the tooltip since this is just a bugfix.

Testing

I made this change in my browser, and now reviewer and file annotations work again.

@kroeschl
kroeschl marked this pull request as ready for review October 12, 2026 17:32

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant