Repository navigation
fix(mcp): rename deploy_noop_destination_to_cloud name param to destination_name - #1416
Conversation
…nation_name Match deploy_destination_to_cloud and add Field descriptions for the destination_name and unique parameters. Fixes airbytehq#1203.
|
Note 📝 PR Converted to Draft More info...Thank you for creating this PR. As a policy to protect our engineers' time, Airbyte requires all PRs to be created first in draft status. Your PR has been automatically converted to draft status in respect for this policy. As soon as your PR is ready for formal review, you can proceed to convert the PR to "ready for review" status by clicking the "Ready for review" button at the bottom of the PR page. To skip draft status in future PRs, please include |
👋 Welcome to PyAirbyte!Thank you for your contribution from anhdoox/PyAirbyte! We're excited to have you in the Airbyte community. 💡 Show Tips and TricksTesting This PyAirbyte VersionYou can test this version of PyAirbyte using the following: # Run PyAirbyte CLI from this branch:
uvx --from 'git+https://github.com/anhdoox/PyAirbyte.git@fix/1203-noop-destination-name' pyairbyte --help
# Install PyAirbyte from this branch for development:
pip install 'git+https://github.com/anhdoox/PyAirbyte.git@fix/1203-noop-destination-name'PR Slash CommandsAs needed or by request, Airbyte Maintainers can execute the following slash commands on your PR:
📚 Show Repo GuidanceHelpful ResourcesIf you have any questions, feel free to ask in the PR comments or join our community:
|
|
Tram Anh (@anhdoox) - Thanks for your contribution! Reviewing now. 👀 |
There was a problem hiding this comment.
🟢 Approval recommended
Static review found no blocking issues in the narrowly scoped rename and accompanying tests; tests were not executed.
No open issues 🎉
What changed in this PR
Aligns deploy_noop_destination_to_cloud with the other deployment tools by renaming name to destination_name, addressing #1203. Clients using name= must update; no compatibility alias is retained.
Changes:
- Renames the parameter while preserving deployment forwarding and defaults.
- Adds descriptions for
destination_nameandunique. - Adds unit tests for argument forwarding, defaults, and parameter descriptions.
| File | Description |
|---|---|
| tests/unit_tests/test_mcp_cloud.py | Adds coverage for the renamed parameter, defaults, and descriptions. |
| airbyte/mcp/cloud.py | Renames the parameter and documents its schema metadata. |
Review effort: Balanced
f002bbf
into
airbytehq:main
Fixes #1203.
nameparameter todestination_nameto matchdeploy_destination_to_cloud.destination_nameandunique.Note: this is a breaking rename for MCP clients that pass 'name='. No alias kept, since no other MCP tool keeps aliases for renamed params. Happy to add one if preferred.