Skip to content

fix(mcp): rename deploy_noop_destination_to_cloud name param to destination_name - #1416

Merged
Aaron ("AJ") Steers (aaronsteers) merged 2 commits into
airbytehq:mainfrom
anhdoox:fix/1203-noop-destination-name
Oct 26, 2026
Merged

Aaron ("AJ") Steers (aaronsteers) merged 2 commits into
airbytehq:mainfrom
anhdoox:fix/1203-noop-destination-name

Conversation

@anhdoox

Copy link
Copy Markdown
Contributor

Fixes #1203.

  • Rename the name parameter to destination_name to match deploy_destination_to_cloud.
  • Add Field descriptions for destination_name and unique.
  • Add unit tests for argument forwarding, defaults and parameter descriptions.

Note: this is a breaking rename for MCP clients that pass 'name='. No alias kept, since no other MCP tool keeps aliases for renamed params. Happy to add one if preferred.

…nation_name

Match deploy_destination_to_cloud and add Field descriptions for the
destination_name and unique parameters. Fixes airbytehq#1203.
@github-actions github-actions Bot added the community PRs from community contributors label Oct 21, 2026
@octavia-bot
octavia-bot Bot marked this pull request as draft October 21, 2026 10:13
@octavia-bot

octavia-bot Bot commented Oct 21, 2026

Copy link
Copy Markdown

Note

📝 PR Converted to Draft

More info...

Thank you for creating this PR. As a policy to protect our engineers' time, Airbyte requires all PRs to be created first in draft status. Your PR has been automatically converted to draft status in respect for this policy.

As soon as your PR is ready for formal review, you can proceed to convert the PR to "ready for review" status by clicking the "Ready for review" button at the bottom of the PR page.

To skip draft status in future PRs, please include [ready] in your PR title or add the skip-draft-status label when creating your PR.

@github-actions

Copy link
Copy Markdown

👋 Welcome to PyAirbyte!

Thank you for your contribution from anhdoox/PyAirbyte! We're excited to have you in the Airbyte community.

💡 Show Tips and Tricks

Testing This PyAirbyte Version

You can test this version of PyAirbyte using the following:

# Run PyAirbyte CLI from this branch:
uvx --from 'git+https://github.com/anhdoox/PyAirbyte.git@fix/1203-noop-destination-name' pyairbyte --help

# Install PyAirbyte from this branch for development:
pip install 'git+https://github.com/anhdoox/PyAirbyte.git@fix/1203-noop-destination-name'

PR Slash Commands

As needed or by request, Airbyte Maintainers can execute the following slash commands on your PR:

  • /fix-pr - Fixes most formatting and linting issues
  • /uv-lock - Updates uv.lock file
  • /test-pr - Runs tests with the updated PyAirbyte
  • /prerelease - Builds and publishes a prerelease version to PyPI
  • /evals - Runs the Cloud MCP evals that use the MCP tools this PR changed (/evals full=true runs the full suite)
📚 Show Repo Guidance

Helpful Resources

If you have any questions, feel free to ask in the PR comments or join our community:

📝 Edit this welcome message.

Comment thread tests/unit_tests/test_mcp_cloud.py Fixed
@aaronsteers
Aaron ("AJ") Steers (aaronsteers) marked this pull request as ready for review October 26, 2026 17:09
Copilot AI balanced review requested due to automatic review settings October 26, 2026 17:09
@aaronsteers

Copy link
Copy Markdown
Member

Tram Anh (@anhdoox) - Thanks for your contribution! Reviewing now. 👀

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

Static review found no blocking issues in the narrowly scoped rename and accompanying tests; tests were not executed.

No open issues 🎉

What changed in this PR

Aligns deploy_noop_destination_to_cloud with the other deployment tools by renaming name to destination_name, addressing #1203. Clients using name= must update; no compatibility alias is retained.

Changes:

  • Renames the parameter while preserving deployment forwarding and defaults.
  • Adds descriptions for destination_name and unique.
  • Adds unit tests for argument forwarding, defaults, and parameter descriptions.
File Description
tests/​unit_tests/​test_mcp_cloud.py Adds coverage for the renamed parameter, defaults, and descriptions.
airbyte/​mcp/​cloud.py Renames the parameter and documents its schema metadata.

Review effort: Balanced

@aaronsteers
Aaron ("AJ") Steers (aaronsteers) merged commit f002bbf into airbytehq:main Oct 26, 2026
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community PRs from community contributors

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(mcp): deploy_noop_destination_to_cloud param naming inconsistent (name vs destination_name) and undocumented

4 participants