Skip to content

fix: align AgentSideConnection.to_agent type with AgentFactory #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
extreme-structure wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: align AgentSideConnection.to_agent type with AgentFactory #157

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/acp/agent/connection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

from .._transport import Transport
from ..connection import Connection, MethodHandler
from ..interfaces import Agent, Client
from ..interfaces import Agent
from ..meta import CLIENT_METHODS
from ..schema import (
AcceptElicitationResponse,
Expand Down Expand Up @@ -95,7 +95,7 @@ class AgentSideConnection:

def __init__(
self,
to_agent: Callable[[Client], Agent] | Agent,
to_agent: Callable[[AgentSideConnection], Agent] | Agent,
input_stream: Any,
output_stream: Any = None,
listening: bool = True,
Expand All @@ -119,7 +119,7 @@ def __init__(
@classmethod
def attach(
cls,
to_agent: Callable[[Client], Agent] | Agent,
to_agent: Callable[[AgentSideConnection], Agent] | Agent,
connection: Connection,
*,
use_unstable_protocol: bool = False,
Expand All @@ -133,7 +133,7 @@ def attach(

def _prepare(
self,
to_agent: Callable[[Client], Agent] | Agent,
to_agent: Callable[[AgentSideConnection], Agent] | Agent,
*,
use_unstable_protocol: bool,
) -> tuple[Agent, MethodHandler]:
Expand Down
2 changes: 1 addition & 1 deletion src/acp/stdio.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,7 @@ async def spawn_agent_process(

@asynccontextmanager
async def spawn_client_process(
to_agent: Callable[[Client], Agent] | Agent,
to_agent: Callable[[AgentSideConnection], Agent] | Agent,
command: str,
*args: str,
env: Mapping[str, str] | None = None,
Expand Down
Loading