[Benjamin Elder (BenTheElder)]

TestActorArbitraryPortAccess has been flaking in e2e since the router moved to static-mtls in #2390, e.g. https://github.com/agent-substrate/substrate/actions/runs/39549120410/job/119054007125

client-go closes the whole port-forward when any one connection on it errors:
https://github.com/kubernetes/client-go/blob/v0.37.0/tools/portforward/portforward.go#L549-L550

RouterClient shared one CONNECT port-forward for the life of the client. So one reset from the router failed the tunnel in flight and every Connect after it, which then got "connection refused" from the dead local port. #2961 fixed the same thing in ingressauth by forwarding per attempt.

Why is this needed? (Or link the issue. Open one first for features, API, install or CI changes.)

Fixes a trivial test flake bug, test only change. Spotted while reviewing PRs like #2502

AI use: AI-assisted, I reviewed it.

• Tests pass
• Docs updated

[Davanum Srinivas (dims)]

LGTM

[Benjamin Elder (BenTheElder)]

build started failing in the queue? must be a logical conflict in main, looking

[Davanum Srinivas (dims)]

Benjamin Elder (@BenTheElder) build failure, you will see it if you rebase.

# go.ate.dev/substrate/internal/e2e
internal/e2e/router_client.go:127:14: c.ensureConnectPortForward undefined (type *RouterClient has no field or method ensureConnectPortForward)
internal/e2e/router_client.go:130:11: c.connectAddr undefined (type *RouterClient has no field or method connectAddr)

• Run 1 (7:09 AM EDT, queue base 6c94cf3): https://github.com/agent-substrate/substrate/actions/runs/39768487833
  • run-tests job: https://github.com/agent-substrate/substrate/actions/runs/39768487833/job/119789799749
  • e2e-test job: https://github.com/agent-substrate/substrate/actions/runs/39768487833/job/119789800271
  • e2e-test (envoy, preview) job: https://github.com/agent-substrate/substrate/actions/runs/39768487833/job/119789800073
• Run 2 (11:17 AM EDT, queue base e88ffcd): https://github.com/agent-substrate/substrate/actions/runs/39803475506
  • run-tests job: https://github.com/agent-substrate/substrate/actions/runs/39803475506/job/119910364465
  • e2e-test job: https://github.com/agent-substrate/substrate/actions/runs/39803475506/job/119910363962
  • e2e-test (envoy, preview) job: https://github.com/agent-substrate/substrate/actions/runs/39803475506/job/119910364388

[Benjamin Elder (BenTheElder)]

should be fixed