Repository navigation
Use crypto/rand for upstream DNS transaction IDs - #3020
Merged
Benjamin Elder (BenTheElder) merged 1 commit intoOct 21, 2026
Merged
Benjamin Elder (BenTheElder) merged 1 commit into
Benjamin Elder (BenTheElder) merged 1 commit into
Conversation
Allocate starting upstream UDP DNS transaction IDs from crypto/rand instead of math/rand/v2 so in-flight transaction IDs cannot be predicted from PRNG state.
Bowei Du (bowei)
approved these changes
Oct 21, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 21, 2026
Benjamin Elder (BenTheElder)
approved these changes
Oct 21, 2026
Benjamin Elder (BenTheElder)
left a comment
Benjamin Elder (BenTheElder)
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, re-queueing
Benjamin Elder (BenTheElder)
added
area/security
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pendingRequests.recordpicked the starting upstream UDP DNS transaction ID frommath/rand/v2. Switch tocrypto/randbefore takingpendingRequests.muso in-flight transaction IDs cannot be predicted from PRNG state.Part of #1816.