Repository navigation
netns.GetFromName rejects names that resolve outside /run/netns - #3019
Merged
Lior Lieberman (LiorLieberman) merged 1 commit intoOct 21, 2026
Merged
Lior Lieberman (LiorLieberman) merged 1 commit into
Lior Lieberman (LiorLieberman) merged 1 commit into
Conversation
Lior Lieberman (LiorLieberman)
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3083
GetFromNamepassed the name straight tovishvananda/netns, which joins it onto/run/netns. A name like../../proc/1/ns/netopened a namespace outside that directory.CreateNamedandRemoveNamedalready reject these names. The check moves intovalidateName, andGetFromNamecalls it too.Today only tests call
GetFromName, with names fromnodepath.ActorNetNSName.