Repository navigation
ateworker: reuse completed checkpoint when workload is already stopped - #3015
Open
Chenyi Wang (chw120) wants to merge 1 commit into
Open
Chenyi Wang (chw120) wants to merge 1 commit into
Chenyi Wang (chw120) wants to merge 1 commit into
Conversation
Record a completion marker (.checkpoint-done.json) inside checkpoint-state/ once CheckpointWorkload has written the snapshot files and torn down the workload. If a retry arrives after the workload is gone (for example when atelet restarts or loses the response before moving checkpoint-state/ into local-checkpoints/), ReuseCheckpoint returns the recorded SnapshotFiles and DataSnapshotFiles while they are still intact on disk instead of failing on a missing sandbox.
Chenyi Wang (chw120)
requested review from
Aditya Shantanu (aditya-shantanu) and
Zoe Zhao (zoez7)
October 20, 2026 22:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
ateletrestarts (or loses theCheckpointWorkloadresponse) afterateworkerhas already finished writing the snapshot intocheckpoint-state/and torn down the sandbox/VM,atelethas not yet movedcheckpoint-state/intolocal-checkpoints/<uuid>/or recorded the snapshot insnapshottracker. When the control plane retriesCheckpoint, the replacementateletcallsateworker.CheckpointWorkloadagain against a workload that no longer exists (runsc checkpoint: exit status 128).This PR records an atomic completion marker (
checkpoint-state/.checkpoint-done.json) at the end ofCheckpointWorkloadin bothateworker-gvisorandateworker-microvm. If a retry arrives when the workload is already unhosted (lookupActor(actorUID) == nil),ReuseCheckpointverifies that the marker's fidelity matches and all listedSnapshotFiles/DataSnapshotFilesare still present incheckpoint-state/, returning the cached response immediately instead of re-runningrunsc checkpointor cloud-hypervisor snapshot.Once
ateletmoves the snapshot files intolocal-checkpoints/<uuid>/or resets the actor directory viaresetActorDirs, the marker is invalidated/removed automatically.Part of #2836