Repository navigation
feat(benchmarking): allow --actor-memory to override sweperf template memory limit - #2768
Open
Maria Fernanda Romano Silva (mariafromano-25) wants to merge 1 commit into
Conversation
1 of 2 tasks
Bowei Du (bowei)
added
area/benchmarking
kind/feature
Maria Fernanda Romano Silva (mariafromano-25)
force-pushed
the
sweperf-actor-memory
branch
from
October 20, 2026 06:38
c88b936 to
04aad61
Compare
Contributor
|
/lgtm |
| -e "s|\${SANDBOX_CLASS}|${SANDBOX_CLASS}|g" \ | ||
| -e "s|\${OTLP_ENDPOINT}|${OTLP_ENDPOINT}|g" \ | ||
| -e "s|\${ACTOR_MEMORY}|${ACTOR_MEMORY}|g" \ | ||
| -e "s|\${SWEPERF_ACTOR_MEMORY}|${SWEPERF_ACTOR_MEMORY}|g" \ |
Contributor
There was a problem hiding this comment.
L165 already supports ACTOR_MEMORY. This SWEPERF_ACTOR_MEMORY feels unnecessary.
cc pmandewalkar
… memory limit Allow benchmarking/workloads/deploy.sh to pass explicit --actor-memory into the generated sweperf ActorTemplates while preserving the 4Gi default when --actor-memory is omitted.
Maria Fernanda Romano Silva (mariafromano-25)
force-pushed
the
sweperf-actor-memory
branch
from
October 20, 2026 22:17
04aad61 to
06b917b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow
benchmarking/workloads/deploy.shto pass an explicit--actor-memoryoverride (${SWEPERF_ACTOR_MEMORY}) into the generatedsweperfActorTemplatemanifests while preserving the existing4Gidefault when--actor-memoryis omitted.Split out from #2674 per review feedback.