Repository navigation
Add AbortSignal cancellation to checks and fixture replay - #4
Draft
dKosarevsky wants to merge 1 commit into
Draft
dKosarevsky wants to merge 1 commit into
dKosarevsky wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The harness has per-run timeouts, but a caller cannot currently cancel a long check or replay when a test runner or request is cancelled.
Changes
signal: AbortSignalto check, assertion, and replay options, with a payload-redactedCheckAbortedError.Verification
npm run check: 67 tests, API type checks, packed ESM consumer including cancellation/replay, packed TypeScript consumer; passed on Node 24.19.0.npm run demoandgit diff --check: passed.Exact head
3f1f26c0cca3c1434d4b12a05c10f79ef5d9c431passed all four CI jobs: Node 20/22/24 and eventsource-parser 4.1.1. Fetched that remote commit, verified its tree matches the tested files, and reran the full check plus demo from the clean checkout. No npm publication, tag, release, or persistent publishing-access change is included.