Repository navigation
fix(priority): release popped element references - #90
adrianbrad merged 3 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #90 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 6 6
Lines 550 552 +2
=========================================
+ Hits 550 552 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Thanks, the
|
9e11b37 to
2250d06
Compare
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
adrianbrad
left a comment
There was a problem hiding this comment.
Thanks for the fix and the regression test. I pushed a small commit adding the blank lines wsl_v5 requires so Lint goes green.
One non-blocking note for a follow-up: the comment inside Priority.Reset still says Pop leaves references past the new length, which this PR now prevents, so it could be reworded.
Summary
priorityHeap.Popso the backing array does not retain the removed reference.ExampleBlocking, and add a priorityGetreference-release regression alongside those tests.mainas requested.Validation
ExampleBlockingprinted 2ms instead of 1ms on Windows. Reported separately in ExampleBlocking elapsed-time output varies on Windows #92 as requested.make lintandmake test-coveragewere not run: make, golangci-lint, and a C compiler are unavailable on PATH. The earlier head's validation does not apply to this revision.