Repository navigation
fix: consume ESM generators + archiver@8 to clear npm install deprecations - #849
Open
AnujVishwakarma-src wants to merge 1 commit into
Open
AnujVishwakarma-src wants to merge 1 commit into
AnujVishwakarma-src wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
…tions Regenerates the committed lockfile to pick up the released fixes across the plugin/generator tree, clearing the npm warn deprecated noise on npm install -g @adobe/aio-cli: - aio-cli-plugin-app 14.10.0 (ESM generator loads, yeoman-environment 6, archiver 8) - aio-lib-runtime 7.5.0 (archiver 8) - generator-aio-app 10.1.0 + the ESM generator fleet (yeoman-generator 7) - aio-cli-plugin-console 5.4.4, aio-cli-plugin-app-templates 2.1.4 Result on a real npm install -g (Node 20/22/24): the generator/tar/glob deprecation cluster is gone; glob resolves to 13.x, tar to 7.5.x (patched), npm audit critical 0. Node 22/24 install with zero npm warn deprecated; Node 20 has one residual (node-domexception) from swagger-client's node-20 fallback (see aio-lib-console / APPBLD-4613). Removes now-redundant overrides (tar, @yeoman/conflicter) per check-overrides; keeps @octokit/rest. Raises engines.node to >=20.17.0 to match the tree.
AnujVishwakarma-src
force-pushed
the
APPBLD-5004-wave3-final
branch
from
September 28, 2026 08:30
67dd979 to
95bdf38
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Close out the
npm install -g @adobe/aio-clideprecation cleanup (APPBLD-5004 / APPBLD-4501) by consuming the released fixes across the plugin + generator tree, and verify zeronpm warn deprecatedon Node 20/22/24.Change
Regenerates the committed
package-lock.json(whichnpm i -gresolves from) to pick up:@adobe/aio-cli-plugin-app14.10.0 — ESM generator loads,yeoman-environment6,archiver8@adobe/aio-lib-runtime7.5.0 —archiver8@adobe/generator-aio-app10.1.0 + the ESM generator fleet (yeoman-generator7)@adobe/aio-cli-plugin-console5.4.4,@adobe/aio-cli-plugin-app-templates2.1.4Also:
overrides(tar,@yeoman/conflicter) —bin/check-overrides.jsreports them removable (the tree resolves patchedtarand cleanglobon its own); keeps@octokit/rest.engines.node>=20→>=20.17.0to match the dependency tree (yeoman-environment6).Verification — real
npm install -g(packed tarball, standalone Node)npm warn deprecatedglob@7/8/10,npmlog,gauge,inflight,rimraf,are-we-there-yet,@npmcli/move-file,read-package-json,tar@6.2.1.glob@13.0.6only andtar@7.5.22(patched).npm audit: 🔴 critical 0.prepack(check-overrides + oclif) clean.Full validation report (pre-merge)
1. Static / in-repo (PR branch)
npm testnpm run lintnpm run prepack(check-overrides + oclif)@octokit/restkept, no removable overridesnpm run e2e(e2e.js)--no-extensionsflag →--standalone-app(renamed in plugin-app 14.x, which this PR consumes)2. Before / after — deprecation & vulnerability diff (real
npm install -g)Per-Node results (Before = old plugin-app 14.7.0 · After = plugin-app 14.10.0):
npm warn deprecatednpm auditPackage-level detail (consistent across all three Node versions):
npm warn deprecatedlinestarglobnpm auditThe entire generator/tar/glob deprecation cluster is gone.
2b. Named security advisories cleared (IOEXT-1848)
IOEXT-1848tracked 8 named advisories on aio-cli. All are resolved in the consumed tree (tar@6.2.1→tar@7.5.22,yeoman-environment@4 → 6):Verified via
npm auditagainst the current@adobe/aio-cli-plugin-app@14.10.0tree:tar@6.2.1is gone (onlytar@7.5.22), and none of the 8 advisory IDs appear.3. Real-app command E2E (authenticated, deployed to Stage)
Linked the released plugins (
aio plugins link):aio-cli-plugin-app@14.10.0(archiver 8,aio-lib-runtime@7.5.0),aio-cli-plugin-app-templates@2.1.4.New app (
aio app init):build(2 actions) ✅ ·pack→ validapp.zip(35 files) ✅ ·deploy→ Successful deployment ✅ ·add extension dx/excshell/1→generator-app-excshell@3.1.0(ESM) scaffolded ✅Existing app (real Stage workspace):
build✅ ·pack✅ ·deploy→ Successful deployment ✅ ·aio --version/app --help(plugin load) /app info✅No
ERR_REQUIRE_ESM/ constructor errors on any path. Both archiver@8 zip paths (plugin-appzipHelper, runtimezip) produce valid, deployable artifacts.