Repository navigation
chore: update to framework 5.5.0 - #66
Merged
Merged
Conversation
Use the built-in createEnv command instead of scripts/ensure-env.ts, show a coded, translated NotFoundError, align the response and error rules with the framework's error contract, and replace the bootHttp /health showcase with an example webhook now that the framework serves /health/live and /health/ready.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@adaptivestone/framework^5.5.0. Only the framework moved in the lockfile.createEnvreplacesscripts/ensure-env.ts:npm run devnow runsnpm run cli createEnvbeforenodemon. It copies.env.exampleto.envwith a freshAUTH_SALTand never overwrites an existing.env. The script is deleted;.env.example,AGENTS.mdand the README are updated.GET /person/:idthrowsNotFoundError({ code: 'PERSON_NOT_FOUND', i18nKey: 'person.notFound', message: 'Person not found' }).{ "error": "PERSON_NOT_FOUND", "message": "..." }, andsrc/locales/rutranslates the message.curl..clinerules/01-ResponceType.mdand07-ErrorHandling.mdnow describe what the framework actually answers:{ error?, message, errors?: { field: [msg] } }, with per-field arrays and nodata.HttpErrors.03and08are unchanged for now.bootHttpshowcase registersPOST /webhooks/example(202{ data: { received: true } }) instead ofGET /health, with a note to verify provider signatures withtimingSafeEqualStrings./health/liveand/health/ready, and the README has a "Health checks" row for them.bootHttptest,configureServer.tsand.clinerules/11follow the new route.Verification (in the Docker backend container)
npm run check:types(codegen +tsc) andnpm run check(Biome): passnpm test: 9/9docker compose --profile bun run --rm backend-bun): 9/9createEnvon a fresh copy without.env: creates it with a 64-character salt, keeps every other line, and a second run changes nothingAUTH001;/health/live→ 200, and/health/ready→ 200 with the MongoDB check;POST /webhooks/example→ 202;GET /health→ the framework's 404.