Repository navigation
docs: 5.5.1 — generateToken race answer, existing Health.ts - #24
Merged
Merged
Conversation
…the built-in - 05-models: since 5.5.1, generateToken rejects with the wrong-password BadRequestError when the password changed after the user was loaded. - 13-deploy: an app's controllers/Health.ts from before 5.5.0 replaces the built-in Health controller, so /health/live and /health/ready need it to extend the built-in and declare those routes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Docs for adaptivestone/framework#75 (5.5.1):
generateTokencomment in theUserAPI says that since 5.5.1 a password changed after the user was loaded rejects with the same 400BadRequestErroras a wrong password, so a custom login needs no catch.controllers/Health.tsfrom before 5.5.0 replaces the built-in controller too:/health/liveand/health/readyare not served until it extends the built-inHealthand declares those routes.The docs site builds.
Merge after the 5.5.1 release.