Repository navigation
fix: prevent returning empty v3Logs array in getFillLogs - #276
Open
gabrielstoica wants to merge 2 commits into
Open
gabrielstoica wants to merge 2 commits into
gabrielstoica wants to merge 2 commits into
Conversation
gabrielstoica
requested review from
amateima,
ashwinrava,
dohaki,
gsteenkamp89,
melisaguevara,
mrice32 and
nicholaspai
as code owners
October 21, 2026 09:57
🦋 Changeset detectedLatest commit: b57add6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@gabrielstoica is attempting to deploy a commit to the UMA Team on Vercel. A member of the Team first needs to authorize it. |
amateima
approved these changes
Oct 21, 2026
amateima
self-requested a review
October 21, 2026 10:13
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevents returning an empty
v3Logsarray in thegetFillLogsmethod because an empty array still counts as a value for??. So the function always returns the oldFilledV3Relayresults and ignores the currentFilledRelayones.Now it checks for
v3Logs.lengthinstead to prevent that.