Repository navigation
Replace generated server actions with typed better-call endpoints #28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -55,4 +55,7 @@ apps/web/.data/ | |
| HANDOFF.md | ||
|
|
||
| # build | ||
| **/dist/ | ||
| **/dist/ | ||
|
|
||
| # Local research notes | ||
| /docs/research/**/*.md | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| import { handleHackkitRequest } from "@/lib/runtime"; | ||
| export const runtime = "nodejs"; | ||
| export const dynamic = "force-dynamic"; | ||
| export const POST = handleHackkitRequest; | ||
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,21 +1,12 @@ | ||
| "use client"; | ||
| import { HackKitUIProvider } from "@hackkit/ui"; | ||
| import { createHackkitClient } from "@hackkit/core/http/client"; | ||
| import type * as React from "react"; | ||
| import { hackKitUIActions } from "./_hackkit/ui-action-map"; | ||
|
|
||
| /** | ||
| * Wires Core mutations through HackKit actions. Those actions import the app | ||
| * runtime before resolving a mutation, which is required for Server | ||
| * Action requests that do not execute a page module first. | ||
| * | ||
| * Do not pass `DEFAULT_HACKKIT_UI_ROUTES` (or any map with route builder | ||
| * functions) from this Server Component — those builders are not serializable. | ||
| * Omit `routes` to use the client-side defaults, or pass only string overrides. | ||
| * For custom admin builders, supply a client `navigation` adapter instead. | ||
| */ | ||
| const hackkitClient = createHackkitClient(); | ||
|
|
||
| export function Providers({ children }: { children: React.ReactNode }) { | ||
| return ( | ||
| <HackKitUIProvider actions={hackKitUIActions}> | ||
| {children} | ||
| </HackKitUIProvider> | ||
| <HackKitUIProvider client={hackkitClient}>{children}</HackKitUIProvider> | ||
| ); | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
🔎 Supported by static analysis
🏁 Script executed:
Repository: acmutsa/HackKitPlugin
Length of output: 3571
🏁 Script executed:
Repository: acmutsa/HackKitPlugin
Length of output: 41944
🏁 Script executed:
Repository: acmutsa/HackKitPlugin
Length of output: 18567
🏁 Script executed:
Repository: acmutsa/HackKitPlugin
Length of output: 5654
Add CORS handling for allowed cross-origin mutations.
auth.trustedOriginsis part of the documented HTTP browser contract, andcreateHackkitClientaccepts a custombaseURL. A JSON request from a different trusted origin triggers a preflight. This route exports onlyPOST, and no CORS headers are added by Next configuration, middleware, or the HTTP response helper. The browser therefore stops before sending the mutation.Add an origin-aware
OPTIONSresponse and matching CORS headers for allowed POST responses. DeriveAccess-Control-Allow-Originonly from configured trusted origins. Do not use*with credentials. Preserve the existingOriginandsec-fetch-sitechecks.🤖 Prompt for AI Agents