Repository navigation
Include previous-session error logs in issue reports - #7
Merged
Merged
Conversation
ctoth
force-pushed
the
improve/log-attachments
branch
from
October 29, 2026 18:32
a7bb598 to
36fd1ad
Compare
PR #5 removed the os import from interface.py, so the os.path.isfile call would raise NameError. The report success test now supplies real current and previous-session logs, and a separate test covers missing logs.
ctoth
force-pushed
the
improve/log-attachments
branch
from
October 29, 2026 18:35
36fd1ad to
692ee17
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Attach the previous session's error log to issue reports when it exists.
State
Collect the existing current error log and its .old sibling through the existing log_paths list. Omit missing files, directories and an unavailable error_log_path. Preserve dialog cancellation, metadata, send scheduling and reporting text. Independently based on integrated master; integration PR #1 has now been merged by other work, so its existing composition CI is on master. No open PR is this branch's base.
Decisions and why
app_framework renames errors.log to errors.log.old on the next startup. A report submitted after restarting otherwise omits the preceding crash evidence. issue_reporter already accepts multiple paths; no transport or storage changes are needed. The missing-path behavior also works with app_framework's separate failed-logging PR.
Surprises
The report-feedback worktree has separate changes in progress. This branch does not modify it or include its reporting-wording change.
Next step
Read this PR's existing composition CI. File presence checks do not guarantee a file remains available until the sender opens it. No production submission, merge or release.