Repository navigation
Conversation
Clone, the Agentic Studio connector views and frictionless onboarding record resource.created/deleted (Zipstack/unstract-cloud#1880). Agentic Studio projects and lookups still record only their sharing. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ritwik-g
left a comment
ritwik-g
left a comment
There was a problem hiding this comment.
Standardized PR Review — INITIAL
Verdict — APPROVE WITH NITS
Mode: LITE — single-pass, 19/19 lenses, one reader, no subagents. Eligible: 1 files / 13 lines, no disqualifiers.
Summary — Critical: 0 · High: 0 · Medium: 1 · Low: 0 · Lenses run: 19/19 (N/A lenses listed in the checklist).
Claims checked against Zipstack/unstract-cloud#1880 (worktree at 3b0a552df): clone records resource.created with summary=f"clone of {tool_instance.tool_name}" inside the clone transaction (pluggable_apps/clone_v2/helpers/prompt_studio_clone_helper.py:367-372); the Agentic Studio connector view records create (pluggable_apps/agentic_studio_v1/views/connectors.py:171) and delete (:282) of adapters; onboarding records the default adapters (pluggable_apps/platform_admin/onboarding_service.py:169) and the sample project (:438) with request=None, which record_platform_event resolves to the system actor (backend/platform_audit/recorder.py:80-81). All three hold. Cloud origin/main has no platform_audit reference, so the README's cloud claims are true only once #1880 merges, which the PR body already makes the merge condition.
Findings
Finding #1 is posted inline.
Lens checklist
- Spec & intent — Clean
- Architectural fit & precedent — N/A — documentation only; no code or pattern introduced
- Correctness & edge cases — Clean
- Security — N/A — prose only, no handler, input or secret touched
- Data integrity & migrations — N/A — no schema, data or transaction change
- Concurrency — N/A — no code
- API & contract compatibility — N/A — no wire format changed; the README describes the existing event contract
- Reliability & resilience — N/A — no code
- Performance & cost — N/A — no code
- Observability — N/A — no logs, metrics or traces changed
- Operational safety — N/A — no rollout surface; the merge-order dependency on #1880 is stated in the PR body
- LLM/agent-specific — N/A — no model calls, prompts or agents
- Testing — N/A — documentation only; nothing to exercise
- Dependencies & build — N/A — no dependency or build change
- Code quality — N/A — markdown only; no formatter or lint hook is pinned for markdown, and ruff does not apply
- Doc & comment accuracy — See findings #1
- Cross-document rule consistency — Clean
- On-prem deployment experience — N/A — no Helm, on-prem values, settings or customer docs touched; the README is internal developer docs
- Scaling & workload lifecycle — N/A — no worker, autoscaling or lifecycle config touched
Sweep notes:
- Lens 17:
git log <merge-base>..origin/mainexited 0 with an empty range, so the branch is current and the branch sweep covers the merge result. I grepped the repo forprompt-studio/clone,clone of,frictionless,resource.created,agentic_projectandlookup. The only restatements are in the same README (:226,:233-235), and both still agree. - boundary-sweep: not triggered, because the diff adds no outbound client, endpoint, log line or error path.
- rule-storage-check: 0 to verify, 3 dismissed.
charset(an external MIME parameter) andmetadata=andorganization=(API and kwarg names in the README) are documentation placeholders that no plugin script should implement. None of them is in the changed hunk. - Clean-case pass: the onboarding path records only creates, which fits "come from" (no delete is claimed). The clone event is written on commit inside the transaction, so a clone that rolls back records nothing, and the README claims nothing that conflicts.
Open questions for the author
- None.
Assumptions made
- #1880 merges as reviewed (
3b0a552df). If its emitters change before merge, this paragraph must be re-checked.
…nges Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ritwik-g
left a comment
ritwik-g
left a comment
There was a problem hiding this comment.
Standardized PR Review — FOLLOWUP (round 2)
Verdict — APPROVE
Mode: LITE — single-pass, 19/19 lenses, one reader, no subagents. Eligible: 1 files / 14 lines, no disqualifiers.
Summary — Critical: 0 · High: 0 · Medium: 0 · Low: 0 · Lenses run: 19/19 (N/A lenses listed in the checklist).
Prior context fetched — followup-fetch.sh exited 0 (6 of 6). Since-boundary: ed2107029 (round 1, review 5614327566). Head reviewed: 78ad50dc6.
Scope change — NO. The delta since ed2107029 is one sentence in backend/platform_audit/README.md:277-278, at the round-1 finding site; no new files, surfaces or tests.
Prior findings status
#4348455680[Medium] "only their sharing is" omits co-owner events foragentic_projectandlookup→RESOLVED—backend/platform_audit/README.md:277-278now reads "only their sharing and co-owner changes are" (commit78ad50dc6). Verified: on unstract-cloudorigin/main(d0ce9627b),AgenticProjectViewSet(backend/pluggable_apps/agentic_studio_v1/views/projects.py:58-59) andLookupDefinitionViewSet(backend/pluggable_apps/lookups/views/definition.py:64-65) mix inOwnerManagementMixinandResourceShareManagementMixin. On OSSorigin/main(4139b4e91),backend/permissions/membership_views.py:48-49and:73-74recordRESOURCE_CO_OWNER_ADDEDandRESOURCE_CO_OWNER_REMOVED. The create/delete half still holds: unstract-cloud#1880 (3b0a552df) adds no emitter for either kind.
New findings — none.
Lens checklist
- Spec & intent — Clean
- Architectural fit & precedent — N/A — documentation only
- Correctness & edge cases — Clean
- Security — N/A — prose only; no handler, input or secret
- Data integrity & migrations — N/A — no schema or data change
- Concurrency — N/A — no code
- API & contract compatibility — N/A — no wire format change; the README describes existing events
- Reliability & resilience — N/A — no code
- Performance & cost — N/A — no code
- Observability — N/A — no logs, metrics or traces changed
- Operational safety — N/A — no rollout surface
- LLM/agent-specific — N/A — no model, prompt or agent path
- Testing — N/A — documentation only
- Dependencies & build — N/A — no dependency or build change
- Code quality — N/A — markdown only; no pinned markdown linter
- Doc & comment accuracy — Clean
- Cross-document rule consistency — Clean
- On-prem deployment experience — N/A — internal developer README; no chart, values or customer doc
- Scaling & workload lifecycle — N/A — no worker, autoscaling or lifecycle config
Sweep notes:
- Lens 17: the branch is current with
origin/main(git log ed2107029..origin/mainis empty). The other restatement,README.md:233-235("agentic_projectandlookup, whose sharing is recorded through the same endpoints"), says nothing exclusive, so it does not contradict the new sentence. - boundary-sweep: not triggered. The diff adds no outbound client, endpoint, log line or error path.
- rule-storage-check: 0 to verify, 3 dismissed (external tool or documentation placeholder):
charset,metadata=andorganization=are on unchanged README lines. - Clean-case pass: the new clause claims only what is recorded (sharing and co-owner add/remove). Both are emitted by the shared OSS mixins the two cloud viewsets inherit, so no kind is claimed that the code does not record.
Open questions / assumptions
- The assumption from round 1 still applies: the README's cloud claims hold once unstract-cloud#1880 merges as reviewed (
3b0a552df).
 [Low impact] This documentation-only PR appears safe to merge after the companion cloud PR.
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
|
Unstract test resultsPer-group results
Critical paths
|
What
backend/platform_audit/README.md, "What is not recorded": Prompt Studio clone, the Agentic Studio connector views and frictionless onboarding now recordresource.created/resource.deleted, so the README no longer lists them as unrecorded. Agentic Studio projects and lookups still record only their sharing, and the README says so.Why
How
Can this PR break any existing features? If yes, please list possible items. If no, please explain why.
Related Issues or PRs
Notes on Testing
🤖 Generated with Claude Code