Repository navigation
Limit the wait for community news at launch - #3072
Merged
Licho1 merged 2 commits intoNov 9, 2026
Merged
Conversation
UpdatePublicCommunityInfo runs before the engine starts, also for Steam. When the server does not answer, the launcher waited for the HttpClient default (100 s) or longer: on Mono a dropped TCP connect waits for the OS limit (about 130 s). The news is optional, so stop after 10 s and start the engine with the existing news file. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Licho1
requested changes
Nov 9, 2026
The launcher calls this on its UI thread. Running the query with Task.Run keeps its continuations off that thread, so waiting on it cannot deadlock. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Licho1
approved these changes
Nov 9, 2026
Licho1
enabled auto-merge (squash)
November 9, 2026 18:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The launcher loads community news before it starts the engine, also for Steam. When the server does not answer, this blocked the start for 100 s (HttpClient default), or about 134 s on Mono when the TCP connect gets no reply.
News is optional, so this change stops the wait after 10 s. The engine then starts with the existing news file.
Tested with the real
ContentServiceClienton Mono 6.8: hung server 100 s -> 10 s, dropped connect 134 s -> 10 s; a working server still writescommunity.json. Not tested on the Steam build itself.Fixes ZeroK-RTS/Chobby#931
This PR was made with AI help (Claude Code); I checked the change and the test.
🤖 Generated with Claude Code