Repository navigation
test(setup): check the agent prompt stream in the no-prompt tests - #643
Merged
Merged
Conversation
The agent prompt now runs inside cli-core's own readSecret, so the package mock no longer sees it: `input.prompts` staying empty proved only that no login prompt ran. The machine-mode and CI tests now also capture the prompt stream and assert "Agent [" never appears there. The mock stays: the phone, code and password prompts still use it. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #641 the agent prompt runs inside cli-core's
readSecret, out of reach of the test's package mock. Two tests ("never asks about agents in machine mode", "skips the optional agent question under CI") asserted onlyinput.promptsempty, which now proves just that no login prompt ran. They now also capture the prompt stream and assertAgent [never appears.The mock stays: phone, code and password prompts in
session.tsstill go through it. Test-only change.Checks: lint, typecheck, test.
🤖 Generated with Claude Code