Repository navigation
feat(services): expose document passage helper for review hosts - #1679
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Memo's project review can show a document excerpt but cannot reuse the paragraph context already available in gathering: the pure helper was internal. Export
documentPassagefrom the public./servicesentry so findings/key-document review can use the same implementation.No paragraph algorithm, store, provider, schema, command or permission behavior changes. The helper reads caller-supplied text only; hosts retain reference/account binding, validated windows and read budgets. Document the boundary and add the SDK changelog entry.
Validation in temporary HOME/XDG/store/state: all 24 project-gathering tests pass; package build and docs checks pass; an actual built public-entry import returns the expected three paragraph excerpts and found marker. Memo consumer regression coverage for CLI/MCP document review follows in its own PR. No owner data used.