Fix quoted DLL paths in review command prompts - #5426
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The command guard rejected required Codex reviews when their quoted prompt mentioned the repository-built DLL. Recognize supported prompt/document/display arguments as data while preserving conservative rejection of unknown command forms, actual unsupported DLL execution and active shell syntax.
Extend the existing shared contract matrix across the core, Codex PreToolUse/PermissionRequest and Claude PreToolUse. Regression cases cover quoted and multiline prompts, literal separators, substitutions, comments, redirections, negation, compound commands, execution wrappers, indirect hosts and line continuations.
Fixes #5417
Validation
PYTHONDONTWRITEBYTECODE=1 python3 -B -m unittest discover -s .agent_harness/tests— 49 tests passed, including the expanded shared adapter matrix.dotnet build— passed with no warnings or errors.dotnet run --project tools/CodeIndex.Changelog -- check— passed.git diff --check— passed.The implementation changes Python guard behavior only; no .NET runtime behavior or dependency changes are included.
Documentation and changelog
AGENT_GUIDE.mdto document the supported data arguments and conservative fallback.TESTING_GUIDE.md.changelog.d/unreleased/5417.fixed.md;CHANGELOG.mdis unchanged.AGENTS.mdandCLAUDE.mdare unchanged.Unknown DLL-bearing command forms and wrappers remain blocked. Use a direct supported review command, or a body file for complex document content.
Follow-up candidates
None.