Skip to content

Fix quoted DLL paths in review command prompts - #5426

Merged
Widthdom merged 3 commits into
mainfrom
fix-issue5417
Sep 22, 2026
Merged

Widthdom merged 3 commits into
mainfrom
fix-issue5417

Conversation

@Widthdom

Copy link
Copy Markdown
Owner

Summary

The command guard rejected required Codex reviews when their quoted prompt mentioned the repository-built DLL. Recognize supported prompt/document/display arguments as data while preserving conservative rejection of unknown command forms, actual unsupported DLL execution and active shell syntax.

Extend the existing shared contract matrix across the core, Codex PreToolUse/PermissionRequest and Claude PreToolUse. Regression cases cover quoted and multiline prompts, literal separators, substitutions, comments, redirections, negation, compound commands, execution wrappers, indirect hosts and line continuations.

Fixes #5417

Validation

  • PYTHONDONTWRITEBYTECODE=1 python3 -B -m unittest discover -s .agent_harness/tests — 49 tests passed, including the expanded shared adapter matrix.
  • dotnet build — passed with no warnings or errors.
  • dotnet run --project tools/CodeIndex.Changelog -- check — passed.
  • git diff --check — passed.
  • Root index and workspace manifest freshness checks passed after refresh.
  • Required Codex adversarial review: two rounds completed. All eight findings were addressed with adapter regression cases. The final follow-up passed the full Python suite; no third independent review was run, following the workflow's two-round limit.

The implementation changes Python guard behavior only; no .NET runtime behavior or dependency changes are included.

Documentation and changelog

  • Updated AGENT_GUIDE.md to document the supported data arguments and conservative fallback.
  • Updated the English and Japanese sections of TESTING_GUIDE.md.
  • Added bilingual fragment changelog.d/unreleased/5417.fixed.md; CHANGELOG.md is unchanged.
  • AGENTS.md and CLAUDE.md are unchanged.

Unknown DLL-bearing command forms and wrappers remain blocked. Use a direct supported review command, or a body file for complex document content.

Follow-up candidates

None.

@Widthdom
Widthdom merged commit 73e73e1 into main Sep 22, 2026
11 checks passed
@Widthdom
Widthdom deleted the fix-issue5417 branch September 22, 2026 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Command guard rejects quoted review prompts mentioning the local DLL path

1 participant