Avoid content-bearing sorts in line-local find - #5425
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Line-local literal/regex
findpreviously sorted chunk content in SQLite before yielding the first line. It now selects chunk metadata in index order, or in 64-row keyset pages on older indexes, and fetches source content separately per chunk. Overlap ownership, missing-source failures, counts, scan limits and continuation positions are preserved without a schema migration or reindex.The legacy sort retains only bounded scalar metadata. Legacy pages and the NULL-content compatibility check may still scan file metadata; individual chunk content is still read in full. No peak-memory or latency benchmark is claimed.
Validation:
make lintpassed.USE TEMP B-TREE FOR ORDER BY; the new ordered query usesidx_chunks_file_start_chunk_nonnullwithout a temporary sort.dotnet run --project tools/CodeIndex.Changelog -- checkandgit diff --checkpassed.Documentation is updated in English and Japanese in
docs/find-scan-controls.mdandTESTING_GUIDE.md. Changelog fragment:changelog.d/unreleased/5415.fixed.md.Fixes #5415