Repository navigation
Test OTP 28 and 29 in CI and fix Dialyzer opaque warning - #6
Closed
robertoaloi wants to merge 1 commit into
Closed
robertoaloi wants to merge 1 commit into
robertoaloi wants to merge 1 commit into
Conversation
Summary: The open-source `assert` CI only tests OTP 27, although the library supports OTP 27 and later. Dialyzer from OTP 28 onwards (whose opaque type checking was reworked by EEP-69) reports an opaqueness warning in `wa_assert_parse_trans:get_line/1` that OTP 27 does not, so the green CI hides a warning users on OTP 28/29 see. CI now runs on OTP 27, 28 and 29 on both Linux and macOS, with `fail-fast` disabled so one failing version does not cancel the others, and a per-OTP Dialyzer PLT cache. `get_line/1` no longer guards with `is_integer/1` on the opaque `erl_anno:anno()`, relying on `erl_anno:is_anno/1` and `erl_anno:line/1`, which already handle plain integer lines, so behaviour is unchanged. Differential Revision: D122547164
|
@robertoaloi has exported this pull request. If you are a Meta employee, you can view the originating Diff in D122547164. |
|
This pull request has been merged in 95e1c60. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The open-source
assertCI only tests OTP 27, although the library supports OTP 27 and later. Dialyzer from OTP 28 onwards (whose opaque type checking was reworked by EEP-69) reports an opaqueness warning inwa_assert_parse_trans:get_line/1that OTP 27 does not, so the green CI hides a warning users on OTP 28/29 see.CI now runs on OTP 27, 28 and 29 on both Linux and macOS, with
fail-fastdisabled so one failing version does not cancel the others, and a per-OTP Dialyzer PLT cache.get_line/1no longer guards withis_integer/1on the opaqueerl_anno:anno(), relying onerl_anno:is_anno/1anderl_anno:line/1, which already handle plain integer lines, so behaviour is unchanged.Differential Revision: D122547164