Repository navigation
fix: write_zarr_zip warning suppression in R io - #170
Merged
Merged
Conversation
Take UserWarning from import_builtins() instead of the warnings module, where it does not exist and raised an AttributeError. Wrap the write in reticulate's with() so __enter__ and __exit__ act on the same catch_warnings() object. Previously a fresh object was exited, raising a RuntimeError and leaking the ignore filter into the session. Closes #167
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug fixes
write_zarr_zipinscripts/r/_io.R: importUserWarningfromimport_builtins().write_zarr_zipinscripts/r/_io.R: wrap writing in reticulate'swith().Related issues
Closes #167