Repository navigation
Await OpenAPI authorization and handler disposal - #141
Open
RichardHoekstra wants to merge 1 commit into
Open
RichardHoekstra wants to merge 1 commit into
RichardHoekstra wants to merge 1 commit into
Conversation
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The OpenAPI dispatcher launches context cleanup with
void. Handlers can start before authorization cleanup finishes, and responses can return while handler resources remain alive. Cleanup rejections are detached.Change
Use
await usingwithin the existing timing scopes. Finish authorization disposal before handler dispatch and handler disposal before returning. Preserve combined operation/disposal errors throughSuppressedError.Validation
system.nodejs.test_openapicleanupfails before and passes after. Seven tests exercise the real dispatcher with cleanup barriers, failures, denied authorization and an independent overlapping request.Selected compatibility, TypeScript and unchanged ESLint checks pass.
Compatibility
Cleanup contributes to phase timing and request outcome. A cleanup error after a committed effect does not imply rollback.
Validated on the official 6.2 image for GitHub main
a91a7a28, with the candidate sources installed. Full upstream CI has not been run.