Repository navigation
Finish CodeContext cleanup after disposer failures - #139
Open
RichardHoekstra wants to merge 1 commit into
Open
RichardHoekstra wants to merge 1 commit into
RichardHoekstra wants to merge 1 commit into
Conversation
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A throwing listener or disposer aborts
CodeContext.close()before later resources are disposed and the context is closed. Concurrent callers can dispose resources independently.Change
Share one close promise, attempt all cleanup, preserve failures, then clear storage and mark the context closed. Cleanup retains scoped-resource access until disposal finishes.
Validation
system.nodejs.test_codecontext_cleanupfails before and passes after. Seven regressions cover listener/disposer failures, error aggregation, concurrent close, inherited callbacks and PostgreSQL lock release.Selected compatibility, TypeScript and unchanged ESLint checks pass.
Compatibility
One failure is preserved unchanged; multiple failures produce an
AggregateError. This adds no forced cancellation or cleanup deadline.Validated on the official 6.2 image for GitHub main
a91a7a28, with the candidate sources installed. Full upstream CI has not been run.