Repository navigation
Preserve rollback failures after commit preparation fails - #137
Open
RichardHoekstra wants to merge 1 commit into
Open
RichardHoekstra wants to merge 1 commit into
RichardHoekstra wants to merge 1 commit into
Conversation
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
If commit preparation and its attempted rollback both fail,
Work.commit()discards the rollback error. A later successful outer rollback can hide that failure permanently.Change
Preserve both original errors in an
AggregateError.Validation
system.nodejs.test_work_prepare_errors: fails before, passes after.Compatibility
The combined failure now has an
AggregateErrorshape. Callers inspecting error classes must handle it; it must not be mistaken for the original retryable database error.Validated on the official 6.2 image for GitHub main
a91a7a28, with the candidate sources installed. Full upstream CI has not been run.