Repository navigation
Reject the pending async IPC promise when receiving throws - #136
Open
RichardHoekstra wants to merge 1 commit into
Open
RichardHoekstra wants to merge 1 commit into
RichardHoekstra wants to merge 1 commit into
Conversation
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
With
autothrowenabled,ReceiveMessage()can throw out ofMessageWaiter.HandleCallback()instead of rejecting the promise that owns the async read.Change
Catch the receive exception, clear the async waiter registration and reject its deferred promise. Return completion so the callback helper releases the registration normally.
Validation
system.nodejs.test_async_ipc: fails before, passes after. Covers both async request/receive APIs, an unrelated promise and a subsequent successful request.No protocol or public API change. Validated on the official 6.2 image for GitHub main
a91a7a28, with the candidate sources installed. Full upstream CI has not been run.