Repository navigation
fix: violations and AI referrals are neither sent twice nor lost during an outage - #106
Merged
Merged
Conversation
…ng an outage - Violation drains take an add_option() lock. Every request that recorded a violation drains at shutdown and the cron drains too; two at once read the same oldest rows and sent them twice. A lock older than 60s is taken over. - A refusal (no answer, 429, 5xx) keeps the batch and its attempts and starts the shared 60s pause; only a rejected batch spends attempts. Before, two refused drains discarded the spool. - AI referrals: a 429 keeps the batch for resend under its id (ingest deduplicates it) instead of deleting it, and flushing waits out the pause. - The test add_option stub now fails on an existing option, as WordPress does.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For WebDecoy/app#1245, item 7.
add_option()lock. A lock older than 60s, left by a request that died, is taken over.Tests:
php tests/run.phpgives 196 passed (7 new, inViolationDrainTest.php).add_optionstub now fails on an existing option, as WordPress does. The existing suite still passes.