Repository navigation
feat(IdeasSummary): Keep ideas with 0 students at bottom when sorting by student count - #2358
Merged
hirokiterashima merged 2 commits intoOct 16, 2026
Merged
Conversation
…g by student count - Configure custom `sortData` on `dataSource` so ideas with 0 students always remain below ideas with at least 1 student in both ascending and descending sorts. - Maintain standard sorting behavior for idea column. - Add unit tests verifying ascending and descending count sorting and idea text sorting. - Disable clear sorting for student count column.
breity
added
the
enhancement
❌ 5 blocking issues (5 total)
|
![qltysh[bot]](https://avatars.githubusercontent.com/in/890766?s=60&v=4){kind=small}
| direction: 'asc' | ||
| } as any); | ||
|
|
||
| expect(sortedAsc.map((r) => r.count)).toEqual([1, 3, 5, 0, 0]); |
| direction: 'desc' | ||
| } as any); | ||
|
|
||
| expect(sortedDesc.map((r) => r.count)).toEqual([5, 3, 1, 0, 0]); |
|
|
||
| if (this.sort) { | ||
| this.dataSource.sort = this.sort; | ||
| } |
| comparatorResult = -1; | ||
| } | ||
| return comparatorResult * (direction === 'asc' ? 1 : -1); | ||
| }); |
|
Coverage Impact Unable to calculate total coverage change because base branch coverage was not found. Modified Files with Diff Coverage (1)
🤖 Increase coverage with AI coding...🚦 See full report on Qlty Cloud » 🛟 Help
|
breity
changed the title
Member
|
🎉 This PR is included in version 5.246.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
When sorting # of students in the Ideas Summary table in the Teacher Tools, keep all ideas with 0 students below the ideas with at least 1 student.
sortDataondataSourceso ideas with 0 students always remain below ideas with at least 1 student in both ascending and descending sorts.Test