Repository navigation
fix: preserve executable chart sources and clarify skill data contracts - #4718
Merged
Merged
Conversation
Preserve helper closures and literal source through generation and editor updates. Validate graph, hierarchy and callback contracts before delivery. Clarify reference paths and layout-datum tooltip access. Keep public dependencies unchanged and maintenance tests outside the runtime skill. Add focused CI for generation contracts.
Separate hierarchy construction from optional styling and tooltip customization. Remove duplicated routing and chart-specific legend rules. Retain scoped maintenance tests and make edge-case regression optional.
666haiwen
marked this pull request as ready for review
October 20, 2026 03:56
xile611
reviewed
Oct 20, 2026
Validate series containers and entries before traversing their configuration. Return configuration errors instead of crashing or reporting source evaluation failure.
xile611
reviewed
Oct 20, 2026
xile611
left a comment
xile611
left a comment
Contributor
There was a problem hiding this comment.
发现 1 项 P2 问题：普通 Sankey 的多数据集配置会被新增校验器误拒绝，建议修复后合入。
验证：Node.js 22 下，76 项 Node 契约测试、45 项 Python 测试通过；另用 Chromium 复现了行内评论中的合法配置，实际绘制出 2 个节点、1 条边，但生成器返回 SANKEY_GRAPH_REQUIRED。现有测试仅覆盖 common + series 的数据集选择，未覆盖普通 Sankey 的同类场景。
Reject malformed data descriptors with source paths instead of throwing during graph checks. Preserve legend filter keys in customization examples and consolidate API lookup links.
![visactor-review-bot[bot]](https://avatars.githubusercontent.com/u/126661221?s=60&v=4){kind=small}
added 2 commits
October 20, 2026 15:46
Replace misleading custom event string-array guidance with built-in trigger combinations and an event-object example. Codex-Model: GPT-6
Ordinary Sankey charts use the first root dataset for their default series. Keep auxiliary datasets out of graph-shape checks while rejecting malformed selected data. Cover source validation and HTML generation regressions. Codex-Model: GPT-6
xile611
approved these changes
Oct 20, 2026
666haiwen
enabled auto-merge
October 20, 2026 09:01
xile611
disabled auto-merge
October 21, 2026 02:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
背景与方案
Skill 生成的 HTML 编辑器此前仅提取 const spec 对象，导致数据变量和 helper 闭包丢失；图/树数据结构及布局节点与原始记录的关系也缺少清晰说明。
保留上游依赖/CDN 策略；不引入宿主发布协议或私有服务依赖，不修改图表库实现。相关工作：#4713。
验证与边界
变更类型
Changelog