Repository navigation
Conversation
![visactor-review-bot[bot]](https://avatars.githubusercontent.com/u/126661221?s=60&v=4){kind=small}
There was a problem hiding this comment.
Latest reviewed commit: ba90065
No confirmed new issues found.
Contributor
|
@dyk1454683243-sudo 需要rebase 一下最新的develop |
Plain node and link hover with effect "related" read graphic.data and a missing parents list. Walk upstream and downstream from the rendered link datums instead, and keep the hierarchical parents path unchanged. Co-authored-by: David <dyk1454683243-sudo@users.noreply.github.com>
Plain related emphasis already tracks reachable nodes in a Set. Pass that Set to _highLightElements so state selection is not O(V^2) on large graphs. Hierarchical parents callers still pass arrays. Co-authored-by: David <dyk1454683243-sudo@users.noreply.github.com>
cursor
Bot
force-pushed
the
cursor/sankey-related-emphasis-787d
branch
from
October 16, 2026 06:31
1fd2d52 to
ba90065
Compare
xile611
approved these changes
Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 This is a ...
🔗 Related issue link
Fixes #4707
The same plain node-link path is what #4305 depends on. A reduced numeric
source/targetgraph with a path longer than two hops now highlights the full upstream and downstream path on hover.🔗 Related PR link
None.
🐞 Bugserver case id
Not applicable. This fix comes from the GitHub issue, not a BugServer case.
💡 Background and solution
Hovering a node or a link on a plain
nodes/linkssankey withemphasis: { enable: true, trigger: 'hover', effect: 'related' }threw during interaction. The initial render was fine.Root cause:
nodeElement.data[0]. Mark graphics keep the datum oncontext, and the other sankey paths read it withgetDatumOfGraphic..lengthof a missingparentsarray. The plain-graph branch never ran, and that branch only cleared states.Fix:
parents.parentsratio path unchanged.📝 Changelog
emphasis.effect: 'related'throwing on plain node-link data, and highlight the full upstream and downstream path on node or link hover.emphasis.effect: 'related'时悬停节点或边抛错的问题，并正确高亮上下游整条路径。☑️ Self-Check before Merge
🚀 Summary
copilot:summary
🔍 Walkthrough
copilot:walkthrough