Repository navigation
Conversation
Rui-Sun
marked this pull request as ready for review
October 15, 2026 15:15
Rui-Sun
marked this pull request as draft
October 15, 2026 16:15
Rui-Sun
marked this pull request as ready for review
October 15, 2026 16:36
xile611
reviewed
Oct 16, 2026
xile611
left a comment
Contributor
There was a problem hiding this comment.
审查提交:7dfb6f638cd338af596658148bb0918359be4278。发现 1 个已复现的 P2 问题,详见行内意见。
验证范围:Node.js 22 下,已有输出目录时,派发校验、套件导出和 JSON 输出共 31 项测试通过,候选执行 11 项测试通过(复用已有构建);移开已有 .vchart-visual 目录后,单独运行 JSON 专项稳定复现 ENOENT。未重跑全量视觉测试。
|
|
||
| test('native JSON preserves preparation failure, source snapshots and cleanup', async () => { | ||
| // 使用独立 Git 工作区故意缺少依赖;设置模块改动模拟检查期间的源码变化。 | ||
| const dir = await fs.mkdtemp(path.join(root, '.vchart-visual/json-contract-')); |
Contributor
There was a problem hiding this comment.
[P2] 创建临时目录前先初始化父目录
这里直接调用 fs.mkdtemp(),但没有创建父目录 .vchart-visual。在全新检出、尚未运行视觉测试时,单独执行文档中的 node --test packages/vchart/scripts/visual-json.test.mjs 会立即报 ENOENT: no such file or directory, mkdtemp .../.vchart-visual/json-contract-...,因此无法验证后续 JSON 契约断言。已在 Node.js 22 下移开已有输出目录后复现。组合运行时 visual-suite.test.mjs 会提前创建该目录,掩盖这个依赖。建议在 mkdtemp 前执行 await fs.mkdir(path.join(root, '.vchart-visual'), { recursive: true }),让该专项能独立运行。
…rkflow-local-check
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
提供核心与扩展独立的原生视觉套件导出、指定基准候选执行和固定
workflow_dispatch受理入口。多区域 Brush 每轮布局统一重置状态,消除重复扫描全图;CI 复用同轮构建资源,保留原生分片与原报告,并明确检出 PR head。同步官方已合入的 VRender 1.1.12 / VUtils 1.0.28,修复斜体标注文字的布局差异。当前 head:
ca4a94eae5efbb291f22d940af58ae2dd4506a6d;本轮固定官方 develop 基线:e41a07fee23214f146698a5f8f3b30a96dc39339。验证:
旧入口仍失败:Photo 为 2093 项 / 2037 成功,56 项未通过;官方参考 #4713 为 2093 / 2039,具体失败集合尚未比对。size 为 2.42 MB / 2 MB,官方参考也超限(422.45 kB,本分支 422.42 kB)。原失败保留,生产基准及阈值保持。
本 PR 继续等待管理员 review,未合入。固定运行包与受控依赖已取得 VChart 产品准入;可信宿主只允许有界
unpkg.com:443TLS 隧道,worker 无通用网络或凭据,浏览器正常验证 TLS、不拦截请求或替换响应;内网/元数据/其他域拒绝及清理已实测。隧道按固定 CDN 端点授权,不能检查加密 HTTP 方法或路径。旧离线 CDN 失败及两次配置加载/工作目录失败证据保留,未改写成通过。固定 dispatch 收据仍为testsExecuted=false;默认分支真实自动派发、生产接入和资产发布仍需独立验收。