Repository navigation
docs: 修复 VChart Skill 教程图片失效 (#4700) - #4706
Merged
Merged
Conversation
skie1997
reviewed
Oct 14, 2026
skie1997
left a comment
Contributor
There was a problem hiding this comment.
已审查当前提交 6fff2041c1a060800791f3c3d6212bb3812b504b,未发现本次改动引入的、需要修复的问题。
本次独立核对了完整 diff,并从该提交读取 5 张 WebP 完成解码和内容检查:文件名与安装、目录、生成图表、调整样式、修复配置的用途对应;尺寸、字节数和 SHA-256 与记录一致。中英文共 10 处引用均指向存在的静态文件,正文和 alt 文本保持不变,路径沿用已有 /vchart/guide/... 资源约定,git diff --check 通过。
CI 状态仍需单独处理:
- size 检查:
build/index.min.js为 2.45 MB,超过 2 MB 限制。该检查针对 JS 产物,本 PR 未改动其源码、依赖或构建配置。 - BugServer 检查:返回 totalCount=2093、successCount=2050,后续脚本以退出码 1 结束。目前没有证据将此失败归因于图片引用修改,仍需维护者确认。
本次没有重跑全量图表测试或复现 PR 描述中的浏览器验收。官网是否恢复显示,需要文档与静态资源发布后再确认;上述结论不代表 CI 全绿或线上已修复。
skie1997
approved these changes
Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
《VChart Skill 使用》中英文教程的 5 张截图引用了已失效的签名地址,官网无法显示图片。本次恢复原文同一资源 ID 的 WebP 文件,随文档静态资源发布,并同步替换双语引用。
🤔 这个分支是...
🔗 相关 issue 链接
Fixes #4700
💡 问题的背景&解决方案
docs/public/vchart/guide/skill-usage/,中英文教程共 10 处引用改为/vchart/guide/skill-usage/*.webp,访问不再依赖到期签名。docs/superpowers/plans/2026-10-14-fix-skill-tutorial-images.md。📝 Changelog
☑️ 自测
200 image/webp,SHA-256 与原文件一致。node packages/vchart/scripts/visual-test.mjs,与官方 develop704033074a29a77ac90ed7c045d4b108af36ef05完整比较:266 passed,0 diff,0 error,0 not_run。rush test --only tag:package通过:136 个测试套件、1219 个断言(VChart 96/546、Statplots 39/672、VUtils Extension 1/1)。git diff --check通过。默认
rush docs存在已有的包子路径别名错误(index.ts/esm/...),未将其记录为通过。本次使用仓库外临时 Vite 配置限定别名精确匹配和依赖扫描入口,完成真实 React 文档页面验收;正式配置与依赖未修改。官网需要文档站发布后再验收,本次本地验证不代表线上已经恢复。
🚀 Summary
copilot:summary
🔍 Walkthrough
copilot:walkthrough