Repository navigation
fix: cancel the pending speech-end timer when a call is torn down - #183
Closed
RaphaelFakhri wants to merge 1 commit into
Closed
RaphaelFakhri wants to merge 1 commit into
RaphaelFakhri wants to merge 1 commit into
Conversation
Author
|
Closing to keep the number of open PRs here manageable. Happy to reopen if it is still useful. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
stop()and the internalcleanup()setspeakingTimeouttonullwithout callingclearTimeout. The timer that emitsspeech-endstays scheduled, so it still fires after the call is torn down.Problem
When the assistant is speaking,
handleRemoteParticipantsAudioLevelschedules aspeech-endtimer 1 second out. If the call ends inside that window:speech-endis emitted aftercall-end, up to 1 second late.Vapiinstance, the stale timer fires during the new call. It emits aspeech-endthat does not match aspeech-start, and it clears the reference to any timer that the new call has created since.Solution
Add
endSpeaking(). It clears the pending timer and, if the assistant was speaking, emitsspeech-endimmediately sospeech-startandspeech-endstay paired.stop()andcleanup()call it in place ofthis.speakingTimeout = null.Testing
Adds
__tests__/speaking-timeout.test.ts(fake timers, no browser):speech-endin the next call.speech-endis emitted once, synchronously, when the call is torn down while the assistant speaks.speech-startthenspeech-endsequence is unchanged.Run with
npx jest __tests__/speaking-timeout.test.ts. Without the change tovapi.ts, 2 of 3 tests fail. With it, 3 pass. The full suite passes andtsc --noEmitis clean.