Repository navigation
[k2] log error on OOM in pool allocator - #1704
Merged
Merged
Conversation
Shamzik
added
runtime
Shamzik
requested review from
LLirikkkk and
apolyakov
and removed request for
LLirikkkk
October 9, 2026 10:26
LLirikkkk
previously approved these changes
Oct 10, 2026
apolyakov
requested changes
Oct 10, 2026
apolyakov
reviewed
Oct 13, 2026
Replace OOM assertions in pool_allocator::alloc/calloc/realloc_script_memory with raise_out_of_memory() that logs MemoryStats (current/peak usage, arena limit, total allocations, defragmentation calls, free pieces) before exiting, so OOM failures can be diagnosed from logs.
denisichh
requested changes
Oct 14, 2026
When a trace is present, contextual tags are capped at TAGGED_ENTRIES_BUFFER_SIZE - 1 so the trace is never dropped. Co-Authored-By: Claude Code <noreply@anthropic.com>
raise_out_of_memory() now takes a context string and is reused for the platform allocation failure in request_extra_memory(), so memory usage statistics are logged in a single place. The message no longer mentions the extra-memory request, decoupling it from the allocation strategy. Co-Authored-By: Claude Code <noreply@anthropic.com>
apolyakov
approved these changes
Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces
log::assertionwithlog::errorhandling OOM in pool allocator.It is also rewrites
kphp::log::impl::logfunction so it does not call pool allocator recursivly