Repository navigation
fix(broadcast): keep a caught-up consumer group on a quiet stream (2.1) - #292
Closed
cosmin-staicu wants to merge 1 commit into
Closed
cosmin-staicu wants to merge 1 commit into
cosmin-staicu wants to merge 1 commit into
Conversation
The maintainer counted a group with consumers as stale once its last delivery was older than MaintainerTrimInterval, without checking whether anything newer had been written. On a stream with no traffic every live group was quarantined, deleted after MaintainerQuarantineInterval and recreated by its reader on NOGROUP. A group whose last-delivered-id has reached the stream's last-generated-id is now healthy. Signed-off-by: Cosmin Staicu <cosmin.staicu@uipath.com>
cosmin-staicu
requested review from
alinahornet,
cosminvlad,
florin-munteanu-uipath,
litheon,
lucianaparaschivei and
razvalex
as code owners
October 24, 2026 07:11
|
Member
Author
|
Folded into #293. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Backport of #290 to 2.1.x.
The stream maintainer counted a consumer group with consumers as stale once its
last-delivered-idwas older thanMaintainerTrimInterval. It never checked whether anything newer had been written. On a stream with no traffic, every live group was quarantined, deleted afterMaintainerQuarantineInterval, and recreated by its reader on the nextNOGROUP. That repeated every cycle, with warnings,LogRecreatingTopic, andXGROUPcalls that sometimes timed out.A group whose
last-delivered-idhas reached the stream'slast-generated-idis now healthy, and a quarantine it was under is cleared.Tests:
-warnaserrorbuild is clean.The code is the same as #290. Only the CHANGELOG entry differs, because it goes into 2.1's own Unreleased section.