Repository navigation
Conversation
Rust emits confidential seals without vout, but the Go Seal decoded the absent field as uint32 0 and re-emitted vout:0 - inviting consumers to mistake it for txout 0. Make Vout *uint32 omitempty and update the fixture assertion; add a round-trip test pinning the absence.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rust emits confidential seals without
vout, but the GoSealdecoded the absent field asuint320 and re-emittedvout:0— inviting consumers to mistake it for txout 0.Makes
Vouta pointer withomitempty, updates the fixture assertion, and adds a round-trip test pinning that confidential seals decode with nil vout and marshal without the key.Note: no Go toolchain in this env, so
go testcould not run locally — requesting CI.