Repository navigation
Fix/issue 162 - #206
Open
QuanN1011 wants to merge 2 commits into
Open
Fix/issue 162#206QuanN1011 wants to merge 2 commits into
QuanN1011 wants to merge 2 commits into
Conversation
…unit tests for the failing cases
QuanN1011
requested review from
KBui4 and
SoggyRhino
and removed request for
a team and
SoggyRhino
October 4, 2026 04:51
Contributor
|
Hey, just one more thing, could you please add another comment (or edit the PR description) with this PR format? I'll take a look at it afterwards. DescriptionTesting
AI DisclosureChecklist
There are hidden comments in the markdown of this message, so please copy the markdown, not just the text. |
Author
|
Hey Kim,
I've updated the PR description with the requested format.
Quan
…On Tue, Oct 6, 2026 at 3:15 PM Kim Bui ***@***.***> wrote:
*KBui4* left a comment (UTDNebula/api-tools#206)
<#206 (comment)>
Hey, just one more thing, could you please add another comment (or edit
the PR description) with this PR format? I'll take a look at it afterwards.
Description Testing
- Add testing stuff here
AI Disclosure Checklist
- Create this PR
- Perform final self-review
There are hidden comments in the markdown of this message, so please copy
the markdown, not just the text.
—
Reply to this email directly, view it on GitHub
<#206?email_source=notifications&email_token=BG74OSKKONIE2H6QWHWD2LL5SVHHLA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTMMBSGQ3DGMZSHAY2M4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KYZTPN52GK4S7MNWGSY3L#issuecomment-6024633281>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BG74OSOOH6TYBCKZKGC6ZBD5SVHHLAVCNFSNUABFKJSXA33TNF2G64TZHM3DEOJXGQ2TMNBUHNEXG43VMU5TKNRZGYZTAOJZGA22C5QC>
.
Triage notifications, keep track of coding agent tasks and review pull
requests on the go with GitHub Mobile for iOS
<https://github.com/notifications/mobile/ios/BG74OSPYGXDMG2ENUDLXJZ35SVHHLA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTMMBSGQ3DGMZSHAY2M4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KUZTPN52GK4S7NFXXG>
and Android
<https://github.com/notifications/mobile/android/BG74OSLIP5KP222HH2HPTKT5SVHHLA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTMMBSGQ3DGMZSHAY2M4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2K4ZTPN52GK4S7MFXGI4TPNFSA>.
Download it today!
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes Galaxy room parsing to preserve all three rooms in
Galaxy Rooms A, B & C. Keeps explicit building-room pairs togetherso
SU Mall Plinth, JSOM 12.110resolves toJSOM / 12.110.Testing
go test ./parser -count=1— passed.go test ./... -count=1— passed.AI Disclosure
Used ChatGPT/Codex to help write tests, debug the parsing issues,
suggest fixes, explain Go syntax, and draft the PR description.
I reviewed and applied the parser changes and ran the tests locally.
Checklist