Repository navigation
Fix/issue 162 - #205
Open
QuanN1011 wants to merge 2 commits into
Open
Fix/issue 162#205QuanN1011 wants to merge 2 commits into
QuanN1011 wants to merge 2 commits into
Conversation
…unit tests for the failing cases
Contributor
|
Hey, haven't looked too much into this yet, but I noticed you're trying to merge changes from a fork, which is why the tests are failing. Instead of using a fork, please create a branch off the main repository and move the changes there. And similarly, for any future work, use another branch instead. Additionally, we're moving to a new PR template soon, which is the following: DescriptionTesting
AI DisclosureChecklist
Please use this PR template. There are also hidden comments in the markdown of this message, so please copy the markdown, not just the text. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Comet Calendar room parsing so that "Galaxy Rooms A, B & C" keeps all three rooms and returns "Galaxy Room (A, B, & C)". Also keep explicit rooms together so that "SU Mall Plinth, JSOM 12.110" returns "JSOM 12.110" instead of "SU 12.110"