Repository navigation
Work around corrupted layer offset state due to custom extensions - #28
Merged
Merged
Conversation
GarboMuffin
changed the title
…s in destroyDrawable
GarboMuffin
force-pushed
the
fix-extensions-corrupting-internal-state
branch
from
October 14, 2026 05:13
3aca438 to
8fc4ad9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Certain custom extensions, such as SharkPool Layer Control, thoroughly corrupt internal state by rearranging drawables outside the layer they ought to belong to. This breaks a lot of things in various ways. One of the things it breaks is the loop where we try to find the drawable by checking where it's layer start and ends. The impact of this corruption is severe enough that it's best if we work around it.