Repository navigation
駅名検索で完全一致・前方一致を取得上限より先に優先する - #1721
Merged
Merged
Conversation
Contributor
6 of 10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
「原」などの短い駅名が部分一致する他駅に埋もれ、取得上限から漏れる問題を修正します。名古屋市営地下鉄の原駅が上限10件でも候補に残ります。
変更の種類
変更内容
テスト
make fmtが通ることmake clippyが通ること(wasm32 ターゲットを含む)make testが通ること上記コマンドはすべて成功。原駅の優先順位、ひらがな・カタカナ・大文字ローマ字、上限10件で名古屋の原駅が残ること、到達可能性で絞り込んだ後の上限1件が順位を維持することを回帰テストで確認しました。テストはリポジトリの標準CSVを使用しています。
関連Issue
Closes https://github.com/TrainLCD/Issues/issues/1284
スクリーンショット(任意)
なし(APIの検索順位の修正)。
Summary by CodeRabbit