Repository navigation
feat(app)!: send the command bar to the current session only - #176
Merged
Merged
Conversation
Remove the send-target button from the command bar. Enter in the bar sends to its own session, to the focused pane while split, through sendLine directly: it never reads the window's send target and never asks. The target stays in the Commands tab toolbar and the command editor, which keep sharing it, so "All sessions" set there no longer makes Enter in the bar run on every server. Drop barTarget, the bar's short label and its popover anchor, the send icon and the sendToAllCount string only the bar used. BREAKING CHANGE: the command bar no longer follows the send target; it always sends to the current session. Use the Commands tab or the command editor to send to several sessions. Closes #172 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015nMqJHsqtndDSqJDPp1qYv
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The command bar no longer has a send-target button. Enter in the bar now always sends to the current session, or to its focused pane while it is split. It goes through
sendLinedirectly and never reads the window's send target, so "All sessions" set in the Commands tab can't make Enter in the bar run on every server. The target is still in the Commands tab toolbar and the command editor, which keep sharing it.commandbar.go: the bar row is now icon, input and History.sendBarsends to its own session and empties the bar. It no longer callssendToTargetsor shows the question.sendtarget.go: removedbarTarget, the short label variant (targetLabeltakes no argument now) and thebar-<ID>popover anchor.quickTarget, the picker and the question are unchanged.sendToAllCountstring in both locale files (catalog regenerated) andinternal/icons/svg/send.svg.Changelog: Breaking: the command bar no longer follows the send target. It always sends to the current session. To send to several sessions, use the Commands tab or the command editor's "Send to".
Closes #172
Testing
TestSendTargetAll: with All set in the Commands tab, Enter in the bar reaches only web-1 and asks nothing, including when the target is not yet confirmed. Only web-1's history gets the line. Quick commands still reach every session after the question. Only one target control is shown.TestSendTargetChosen: Choose sessions is now opened from the Commands tab toolbar. Chosen sessions get a quick command after the question, and the bar still sends only to its own (unchosen) session.TestPanesSendToAll: split session plus a second server, with All set from the Commands tab. The bar reaches only the focused pane of the current session, and the other server's shell gets nothing. A quick command asks first, then reaches each session's focused pane once.TestCmdEditorSendAll(unchanged) passes: the editor still reaches every session and asks first.TestCommandBarHistorynow clicks History by name instead of by position after the removed button.gofmtclean,go build ./...,go vet ./...(alsoGOOS=windows, andGOOS=darwinfor the root package),go tool mygo vetandgo test -race ./...all pass.Generated by Claude Code