Skip to content

feat(app): put the server monitor on the right of the terminal - #159

Merged
TooonyChen merged 1 commit into
mainfrom
feature/monitor-right
Nov 9, 2026
Merged

TooonyChen merged 1 commit into
mainfrom
feature/monitor-right

Conversation

@TooonyChen

Copy link
Copy Markdown
Owner

Summary

The server monitor can now move to the column on the terminal's right, the one the bottom panel uses since #158.

  • The monitor's context menu has "Move to right side" / "Move to left side" at its top, then a separator, then the part check boxes.
  • On the right, the session panel fills the left column. monitorPercent is kept for when the monitor comes back.
  • Panel at the bottom: the column holds the monitor alone, full height, and the terminal-over-panel split sits left of it. This also works with the panel collapsed.
  • Panel on the right: the monitor is on top and the panel below, divided at rightMonitorPercent (45% by default, double-click resets, saved). This is the first test of that branch of rightColumn.
  • Panel on the right, hidden, monitor on the right: the panel collapses to its tab row at the bottom of the column, as it does under the terminal. The tab row ends with "Show panel" (chevron up), and the monitor takes the rest of the height. A click on a tab opens the panel on that tab. The thin strip at the terminal's edge would have sat between the terminal and the monitor, which looked out of place, and this reuses the collapsed tab row we already have. When the monitor is in the column with the panel, the panel's hide/show chevrons point down/up, since the panel collapses downward there. When the panel is alone on the right, they are still right/left.
  • A panel row's panel gets the monitor beside it in the right column, still following the current session. Full screen is unchanged.
  • monitorSide and rightMonitorPercent are new settings. They are local (localSettings) and saved and restored with the pane sizes.
  • Small fix: the Processes toolbar's "Reading processes…" is now single-line and cut with an ellipsis in a narrow column.
  • Docs: features.md (Window layout, Server monitor, Layout and split dividers) and configuration.md, in English and Chinese. The README is unchanged because the default layout is unchanged.

Closes #152
Closes #144
Refs #148

Testing

  • New internal/app/monitorright_test.go:
    • TestMonitorOnRight: move right and back through the menu, saved and read back, session list at the top of the left column, terminal narrower, collapsed bottom panel, the monitor's process list still opens Processes, monitorPct unchanged after coming back.
    • TestMonitorAndPanelOnRight: monitor over panel at 45%, divider drag/save/restore/least size/double-click reset, hidden panel as a tab row at the bottom of the column with Show panel, panel back to the bottom, panel row with the monitor beside it, full screen.
    • TestMonitorRightMenuShots.
  • openMonitorMenu in monitorparts_test.go now expects the side item first.
  • go fmt (no changes), go build ./..., go vet ./..., GOOS=windows go vet ., GOOS=darwin go vet . and go tool mygo vet all pass. go test -race ./... passes except TestArchiveTreeMenu, which also fails on main in this sandbox (it tars the real /tmp).
  • I looked at screenshots in English and Simplified Chinese (not committed): monitor right with panel bottom, monitor right with panel right, monitor right with panel hidden, and the monitor's menu.
  • Not tested: a real window on macOS/Windows/Linux, and a live SSH server.

Generated by Claude Code

"Move to right side" at the top of the monitor's context menu puts it in
the column on the terminal's right, and "Move to left side" puts it
back; the session list then fills the left column, monitorPercent kept.
With the bottom panel under the terminal, the monitor has the column
alone; with the panel on the right too, the monitor is on top, divided
at rightMonitorPercent. The panel hidden under the monitor collapses to
its tab row at the column's bottom. A panel row's panel has the monitor
beside it. monitorSide and rightMonitorPercent are saved with the pane
sizes, local. The Processes toolbar's loading text stays on one line.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015nMqJHsqtndDSqJDPp1qYv
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-09T22:09:52.644898Z 5b0ee82 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@TooonyChen
TooonyChen merged commit 59aaced into main Nov 9, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants