Repository navigation
feat(app): put the server monitor on the right of the terminal - #159
Merged
Merged
Conversation
"Move to right side" at the top of the monitor's context menu puts it in the column on the terminal's right, and "Move to left side" puts it back; the session list then fills the left column, monitorPercent kept. With the bottom panel under the terminal, the monitor has the column alone; with the panel on the right too, the monitor is on top, divided at rightMonitorPercent. The panel hidden under the monitor collapses to its tab row at the column's bottom. A panel row's panel has the monitor beside it. monitorSide and rightMonitorPercent are saved with the pane sizes, local. The Processes toolbar's loading text stays on one line. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015nMqJHsqtndDSqJDPp1qYv
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The server monitor can now move to the column on the terminal's right, the one the bottom panel uses since #158.
monitorPercentis kept for when the monitor comes back.rightMonitorPercent(45% by default, double-click resets, saved). This is the first test of that branch ofrightColumn.monitorSideandrightMonitorPercentare new settings. They are local (localSettings) and saved and restored with the pane sizes.Closes #152
Closes #144
Refs #148
Testing
internal/app/monitorright_test.go:TestMonitorOnRight: move right and back through the menu, saved and read back, session list at the top of the left column, terminal narrower, collapsed bottom panel, the monitor's process list still opens Processes,monitorPctunchanged after coming back.TestMonitorAndPanelOnRight: monitor over panel at 45%, divider drag/save/restore/least size/double-click reset, hidden panel as a tab row at the bottom of the column with Show panel, panel back to the bottom, panel row with the monitor beside it, full screen.TestMonitorRightMenuShots.openMonitorMenuin monitorparts_test.go now expects the side item first.go fmt(no changes),go build ./...,go vet ./...,GOOS=windows go vet .,GOOS=darwin go vet .andgo tool mygo vetall pass.go test -race ./...passes exceptTestArchiveTreeMenu, which also fails on main in this sandbox (it tars the real /tmp).Generated by Claude Code