Repository navigation
docs: [docs-drift] termination-metadata - #2768
Closed
timefold-automations[bot] wants to merge 1 commit into
Closed
timefold-automations[bot] wants to merge 1 commit into
timefold-automations[bot] wants to merge 1 commit into
Conversation
timefold-automations
Bot
requested review from
TomCools,
rsynek and
triceo
as code owners
October 21, 2026 06:10
Collaborator
|
We need not document such trivial details. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merged group: #2758 by triceo; TimefoldAI/timefold-solver-enterprise#943 by triceo.
Code change:
TimefoldAI/timefold-solver,core/src/main/java/ai/timefold/solver/core/api/solver/phase/PhaseType.java:12-44, added the publicPhaseTypeenum as part of the termination metadata API.Docs location: No mention found before this fix.
docs/src/modules/ROOT/pages/running-timefold-solver/solver-diagnostics.adoc:528-529now namesPhaseTypeand explains the values returned byPhaseId.type().Confidence: high.
What changed: Documented the new public enum in the run-summary diagnostics section.
Code change:
TimefoldAI/timefold-solver,core/src/main/java/ai/timefold/solver/core/api/solver/termination/TerminationType.java:15-68, added the publicTerminationTypeenum.Docs location: No mention found before this fix.
docs/src/modules/ROOT/pages/running-timefold-solver/solver-diagnostics.adoc:539-540now namesTerminationTypeand gives representative values.Confidence: high.
What changed: Documented the new public enum alongside
TerminationId.Code change:
TimefoldAI/timefold-solver,core/src/main/java/ai/timefold/solver/core/api/solver/event/EventProducerId.java:58-113, deprecated all static event-producer factory methods for removal and introducedPhaseEventProducerIdatcore/src/main/java/ai/timefold/solver/core/api/solver/event/PhaseEventProducerId.java:11-16as the phase-identification replacement.Docs location: No upgrade-guide entry existed.
docs/src/modules/ROOT/pages/upgrading-timefold-solver/upgrade-to-latest.adoc:137-146now lists the deprecated methods and directs users toPhaseEventProducerId.phaseId().Confidence: high.
What changed: Added the required upgrade note for the deprecation and replacement API.
The group is already merged, so this pull request fixes
main. It will be updated if more pull requests on thetermination-metadatabranch merge.