Skip to content

03_fibonacci: Update exercise to return "OOPS" for 0 - #694

Merged
goran1010 merged 4 commits into
mainfrom
fix/update_fibonacci
Oct 2, 2026
Merged

goran1010 merged 4 commits into
mainfrom
fix/update_fibonacci

Conversation

@goran1010

Copy link
Copy Markdown
Member

Because

Asking for the 0th Fibonacci member should return "OOPS" rather than 0.

This PR

  • Fix md lint error in README.md - bare URL
  • Update Instructions in README.md to tell learners to return "OOPS" if given a 0
  • Update tests to reflect new instructions
  • Update solution to reflect new instructions

Issue

Closes #XXXXX

Additional Information

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project Contributing Guide
  • The title of this PR follows the location of change: brief description of change format, e.g. 01_helloWorld: Update test cases
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If this PR includes any changes that affect the solution of an exercise, I've also updated the solution in the /solutions folder

@goran1010

goran1010 commented Oct 2, 2026 •

Copy link
Copy Markdown
Member Author

Wow, somehow I had my origin remote set as the https://github.com/TheOdinProject/javascript-exercises which meant I created a branch on the main repo rather than my own fork 🤦

@mao-sz mao-sz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In advance of below

Comment thread foundations/object_basics/03_fibonacci/solution/fibonacci-solution.js Outdated
…tion.js

Co-authored-by: mao-sz <122839503+mao-sz@users.noreply.github.com>
@goran1010
goran1010 merged commit 1ec6206 into main Oct 2, 2026
2 checks passed
@goran1010
goran1010 deleted the fix/update_fibonacci branch October 2, 2026 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants