Skip to content

fix financial/exponential_moving_average: seed uses window_size values, not window_size+1 #15450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aashish254 wants to merge 1 commit into from
Closed

fix financial/exponential_moving_average: seed uses window_size values, not window_size+1 #15450

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion financial/exponential_moving_average.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@ def exponential_moving_average(
Yields exponential moving averages of the given stock prices.
>>> tuple(exponential_moving_average(iter([2, 5, 3, 8.2, 6, 9, 10]), 3))
(2, 3.5, 3.25, 5.725, 5.8625, 7.43125, 8.715625)
>>> tuple(exponential_moving_average(iter([10.0, 20.0, 30.0]), 1))
(10.0, 20.0, 30.0)

:param stock_prices: A stream of stock prices
:param window_size: The number of stock prices that will trigger a new calculation
Expand Down Expand Up @@ -49,7 +51,7 @@ def exponential_moving_average(
moving_average = 0.0

for i, stock_price in enumerate(stock_prices):
if i <= window_size:
if i < window_size:
# Assigning simple moving average till the window_size for the first time
# is reached
moving_average = (moving_average + stock_price) * 0.5 if i else stock_price
Expand Down
Loading