Skip to content

fix: make bubble sort work with comparable items - #15447

Closed
nikhiltumma wants to merge 1 commit into
TheAlgorithms:masterfrom
nikhiltumma:fix/bubble-sort-comparable
Closed

nikhiltumma wants to merge 1 commit into
TheAlgorithms:masterfrom
nikhiltumma:fix/bubble-sort-comparable

Conversation

@nikhiltumma

@nikhiltumma nikhiltumma commented Sep 27, 2026 •

Copy link
Copy Markdown
Contributor

Fix bubble sort comparisons to use the __lt__ operation defined by the Comparable protocol.

Tests:

  • python sorts/bubble_sort.py
  • python -m doctest -v sorts/bubble_sort.py

All 42 doctests pass.

Checklist

  • I have read the contributing guidelines.
  • I have tested my changes locally.
  • The modified code runs successfully.
  • All existing doctests pass.
  • I have checked that my changes follow the repository's coding style.
  • I have kept my changes focused on the issue.
  • I have not modified the README.md or DIRECTORY.md files.

Fixes #15234

@algorithms-keeper algorithms-keeper Bot added the awaiting reviews This PR is ready to be reviewed label Sep 27, 2026
@algorithms-keeper

Copy link
Copy Markdown

Closing this pull request as invalid

@nikhiltumma, this pull request is being closed as none of the checkboxes have been marked. It is important that you go through the checklist and mark the ones relevant to this pull request. Please read the Contributing guidelines.

If you're facing any problem on how to mark a checkbox, please read the following instructions:

  • Read a point one at a time and think if it is relevant to the pull request or not.
  • If it is, then mark it by putting a x between the square bracket like so: [x]

NOTE: Only [x] is supported so if you have put any other letter or symbol between the brackets, that will be marked as invalid. If that is the case then please open a new pull request with the appropriate changes.

@algorithms-keeper algorithms-keeper Bot removed the awaiting reviews This PR is ready to be reviewed label Sep 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

sorts: make algorithms sort any comparable items, not just ints

1 participant